Open
Conversation
tbu-
reviewed
Apr 27, 2024
Collaborator
tbu-
left a comment
tbu-
left a comment
There was a problem hiding this comment.
Looks generally good to me.
| b.iter(|| { | ||
| v.clear(); | ||
| v.write(&data[..]).ok(); | ||
| v.write_all(&data[..]).ok(); |
Collaborator
There was a problem hiding this comment.
This seems to change the benchmark, it now tests a different function.
| /// This function is `unsafe` because it changes the notion of the | ||
| /// number of “valid” bytes in the string. Use with care. | ||
| /// # Safety | ||
| /// The data must be initialised up to the length provided. |
Collaborator
There was a problem hiding this comment.
This seems to remove the old comment. Was it incorrect?
| // guaranteed to fit due to types matching. | ||
| self.clear(); | ||
| self.try_push_str(rhs).ok(); | ||
| } |
| /// This method is `unsafe` because it changes the notion of the | ||
| /// number of “valid” elements in the vector. Use with care. | ||
| /// # Safety | ||
| /// The data must be initialised up to the length provided. |
Collaborator
There was a problem hiding this comment.
What was wrong about the old comment?
|
|
||
| // exhaust self first | ||
| while let Some(_) = self.next() { } | ||
| for _ in self.by_ref() { } |
Collaborator
There was a problem hiding this comment.
I don't think this is more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all the clippy lints firing for me which improves efficiency and helps new people work on the codebase.